Skip to content

docs: Add PyTorch version badge to README#704

Merged
ValerianRey merged 3 commits into
mainfrom
worktree-add-pytorch-badge
May 27, 2026
Merged

docs: Add PyTorch version badge to README#704
ValerianRey merged 3 commits into
mainfrom
worktree-add-pytorch-badge

Conversation

@ValerianRey
Copy link
Copy Markdown
Contributor

@ValerianRey ValerianRey commented May 27, 2026

  • Adds a badge to the README showing the minimum supported PyTorch version (>=2.3)

This follows from a comment on our pytorch ecosystem application.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ValerianRey ValerianRey added the cc: docs Conventional commit type for changes to the documentation. label May 27, 2026
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ValerianRey ValerianRey marked this pull request as ready for review May 27, 2026 14:25
@ValerianRey ValerianRey requested a review from a team as a code owner May 27, 2026 14:25
@ValerianRey
Copy link
Copy Markdown
Contributor Author

image

Copy link
Copy Markdown
Contributor

@PierreQuinton PierreQuinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. I think I qould like it even better if the python version had the same format (e.g. >=3.10). We could also remove the pre-commit badge, it's pretty useless.

@ValerianRey
Copy link
Copy Markdown
Contributor Author

ValerianRey commented May 27, 2026

I like it. I think I qould like it even better if the python version had the same format (e.g. >=3.10). We could also remove the pre-commit badge, it's pretty useless.

Well, we will always support the last version of torch (and even maybe the nightly version with #707), but we won't always support the last version of Python. This really depends on when our dependencies (well, now "dependecy" because we only have torch as core dep, but still) also start supporting it.
So for example I don't think we can just write >=3.10 without lying a bit about 3.15 compatibility.

@ValerianRey
Copy link
Copy Markdown
Contributor Author

We could also remove the pre-commit badge, it's pretty useless.

Yes I agree. Feel free to make a PR for that

@ValerianRey ValerianRey merged commit 4826347 into main May 27, 2026
16 checks passed
@ValerianRey ValerianRey deleted the worktree-add-pytorch-badge branch May 27, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cc: docs Conventional commit type for changes to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants