fix(RigidObject): add missing UncoupledConstraintCorrection for dynamic objects#138
Open
SlothSpunky77 wants to merge 1 commit into
Conversation
…ic objects RigidObject.py docstring states UncoupledConstraintCorrection is added to dynamic rigid bodies, but the implementation never adds it. This causes FreeMotionAnimationLoop to silently skip constraint propagation on every step, leaving all dynamic objects frozen despite the simulation appearing to run normally. No error is raised. Fix: add UncoupledConstraintCorrection inside the isAStaticObject guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RigidObject.py docstring states UncoupledConstraintCorrection is added to dynamic rigid bodies, but the implementation never adds it. This causes FreeMotionAnimationLoop to silently skip constraint propagation on every step, leaving all dynamic objects frozen despite the simulation appearing to run normally.
No error is raised.
Fix: add UncoupledConstraintCorrection inside the isAStaticObject guard.
I have verified both the issue and the fix against SOFA v26.06.99