SONARPY-4540 Handle built-in type assignments - #2297
Closed
erwan-leforestier-sonarsource wants to merge 2 commits into
Closed
SONARPY-4540 Handle built-in type assignments#2297erwan-leforestier-sonarsource wants to merge 2 commits into
erwan-leforestier-sonarsource wants to merge 2 commits into
Conversation
Author
|
Superseded by the corresponding sonar-python-enterprise PR. |
Code Review ✅ ApprovedUpdates rule S117 to prevent false positives on PascalCase local variables assigned from built-in type() calls, including conditional None fallbacks. No issues found. OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents S117 from reporting PascalCase local variables directly assigned from the built-in
type()function, including a conditionalNonefallback.Changes
typefunction.type(...) if condition else Noneexpressions without broadening the exemption to wrapped calls.typeassignments.Functional Validation
Artifact:
SONARPY-4540-fv.zipOnce the file is attached to the PR description, unzip and run:
./run.sh
Expected output: