SQRA Evals | DO NOT MERGE | SLLS-533 fix: remove unused fakeNotebook variable in test

[sonarqube-agent]

Automated SQRA Evaluation PR DO NOT MERGE

This PR is automatically created for evaluating the SQRA. We will close this PR within next few hours after evaluation. Please DO NOT merge or review this PR. We apologise in advance for the noise created by this PR.

[hashicorp-vault-sonar-prod]

SLLS-533

[sonar-review-alpha]

Summary

Removes an unused local variable fakeNotebook from OpenNotebooksCacheTests.java (line 68). The variable was declared and assigned but never referenced in the test method, creating unnecessary code noise. This addresses the SonarQube issue java:S1481 without affecting test behavior.

What reviewers should know

What to review:

• Verify that fakeNotebook was indeed unused — the diff shows it was created but no test assertions or method calls reference it
• Confirm the remaining test logic is intact: the test still creates the cells, instantiates the cache, and calls didOpen() as intended
• This is a pure cleanup: no logic changes, no behavior modifications

Where to start:
Look at the test method context around line 65-70 to see that removing the variable doesn't break the test setup or assertions below it.

---

• Generate Walkthrough
• Generate Diagram

🗣️ Give feedback

[isuruperera]

@sonar-review-alpha cancel

[sonar-review-alpha]

LGTM! ✅

Clean, minimal removal with no risk. VersionedOpenNotebook.create() is a pure static factory — its constructor only initialises instance fields with no side effects — so dropping the call changes nothing about the test's runtime behaviour. The two other tests in this file that do reference fakeNotebook (in assertions on getContent() and getUri()) are untouched. No test coverage is lost.

🗣️ Give feedback

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
2 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube