Skip to content

CLI-447 Use the declarative framework for migrations#319

Draft
damien-urruty-sonarsource wants to merge 1 commit into
masterfrom
feature/dam/CLI-447-declarative-migrations
Draft

CLI-447 Use the declarative framework for migrations#319
damien-urruty-sonarsource wants to merge 1 commit into
masterfrom
feature/dam/CLI-447-declarative-migrations

Conversation

@damien-urruty-sonarsource
Copy link
Copy Markdown
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource commented May 22, 2026


Summary by Gitar

  • Migration framework:
    • Added migrateDeclarativeIntegrations to runPostUpdateActions to manage feature lifecycle and apply updates.
    • Implemented hasInstalledDeclarativeIntegration to prevent legacy hook migration when declarative integration is active.
  • Claude integration:
    • Configured claudeIntegration to use the declarative framework for sonar-secrets hooks.
    • Added createRemoveObsoleteA3sArtifactsOperation to cleanup legacy SQAA artifacts during migration.
  • Infrastructure:
    • Added ensureBuiltInIntegrationsRegistered to post-update.ts to ensure all integrations are registered before migration.
    • Updated registerGitIntegrations to prevent duplicate registration in the integration registry.
    • Updated git-tools.test.ts to verify registerGitIntegrations is idempotent rather than throwing on duplicate registration.

This will update automatically on new commits.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 22, 2026

Agentic Analysis: Early Results

Agentic Analysis and Context Augmentation are available on your project. Here are some issues that could have been prevented. Follow the links to learn how to put them into action.

1 issue(s) found across 1 file(s):

Rule File Line Message
typescript:S3776 src/lib/post-update.ts 390 Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.

Analyzed by SonarQube Agentic Analysis in 4.9 s

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented May 22, 2026

CLI-447

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the feature/dam/CLI-447-declarative-migrations branch from 29b0ae0 to 8acb20b Compare May 25, 2026 14:19
@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the feature/dam/CLI-447-declarative-migrations branch from 8acb20b to f97b118 Compare May 25, 2026 14:52
@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented May 25, 2026

Code Review ✅ Approved

Refactors CLI migrations to utilize the declarative framework, ensuring robust integration registration and cleaner lifecycle management for feature updates. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@damien-urruty-sonarsource damien-urruty-sonarsource force-pushed the feature/dam/CLI-447-declarative-migrations branch from f97b118 to ef21db0 Compare May 26, 2026 06:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 26, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant