DRAFT (phase 3): depend on apifetch — bdpe_* become thin wrappers#1
Draft
milkway wants to merge 1 commit into
Draft
DRAFT (phase 3): depend on apifetch — bdpe_* become thin wrappers#1milkway wants to merge 1 commit into
milkway wants to merge 1 commit into
Conversation
BigDataPE now delegates all token management and data fetching to the generic apifetch package, supplying only the Big Data PE service conventions (raw Authorization token, limit/offset as headers, drop "Mensagem", PE Conectado hint). Public API and the BigDataPE_<dataset> env-var token names are unchanged (verified by a round-trip), so existing code and stored tokens keep working. Imports trimmed to apifetch; dplyr/tibble moved to Suggests (vignette only). Also fixes author spellings (André, Vasconcelos). NOTE: cannot be released to CRAN until apifetch is accepted on CRAN. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors BigDataPE to depend on the new generic
apifetchpackage. Everybdpe_*function becomes a thin wrapper over itsapifetch::af_*counterpart, supplying only the Big Data PE service conventions via an internal.bdpe_api()profile:af_auth_raw()— token sent verbatim in theAuthorizationheaderaf_paginate_offset("header")—limit/offsetas HTTP headersdrop_cols = "Mensagem"— status column dropped when combining chunksconnect_hint— PE Conectado network / VPN guidanceBackward compatibility
bdpe_*signatures, defaults, and exports.BigDataPE_<dataset>(verified by a store→get→list round-trip), so existing code and already-stored tokens keep working.Dependency changes
Imports: now justapifetch (>= 0.1.0)(cli/dplyr/tibble/httr2 are inherited transitively).dplyr/tibblemoved toSuggests(used only by the vignette).This cannot be submitted to CRAN until
apifetchis accepted on CRAN (CRAN requires all hard dependencies to be available there). Kept as a draft until then.🤖 Generated with Claude Code