Skip to content

[codex] Fix Fade visuals and map rotation#79

Merged
SunkenInTime merged 2 commits into
mainfrom
codex/fade-map-rotation-update
Jun 6, 2026
Merged

[codex] Fix Fade visuals and map rotation#79
SunkenInTime merged 2 commits into
mainfrom
codex/fade-map-rotation-update

Conversation

@SunkenInTime

Copy link
Copy Markdown
Owner

Summary

  • Update Fade's agent icon asset from the current VALORANT API display icon.
  • Make Fade's scan radius visible by removing the zero-opacity override from the Haunt circle.
  • Move Ascent into the active map rotation and Bind into the out-of-play list.
  • Bump the app to 4.3.5+89 and add matching desktop release metadata.

Root Cause

  • Fade's scan circle had a valid purple outline color, but opacity: 0, so the radius rendered invisible.
  • The static map rotation still listed Bind as active and Ascent as out of play.
  • Fade's local icon.webp asset was stale.

Validation

  • Ran fvm dart format lib\const\agents.dart lib\const\maps.dart lib\const\settings.dart.
  • Ran scripts\generate_update_manifest.ps1 against a temp output path and confirmed 4.3.5+89 appears first with shortVersion 89.
  • Ran fvm flutter analyze; it completed with 4 existing prefer_const_constructors infos in test\square_icon_counter_rotation_test.dart and no new errors.

@SunkenInTime SunkenInTime marked this pull request as ready for review June 6, 2026 19:18
Copilot AI review requested due to automatic review settings June 6, 2026 19:18
@SunkenInTime SunkenInTime merged commit 41efd9f into main Jun 6, 2026
2 of 3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Valorant content/config and release metadata to reflect a new app version, including a visual fix for Fade’s Haunt radius and an updated map rotation.

Changes:

  • Bump app version to 4.3.5+89 (including desktop msix_version) and add matching desktop release metadata.
  • Fix Fade’s Haunt scan radius rendering by removing the opacity: 0 override.
  • Update map rotation: move Ascent into rotation and Bind out of rotation.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
release/metadata/4.3.5+89.json Adds desktop release metadata for version 4.3.5+89.
pubspec.yaml Bumps Flutter app version and MSIX version.
lib/const/settings.dart Updates in-app version constants to 4.3.5 / 89.
lib/const/maps.dart Swaps Ascent/Bind between in-rotation and out-of-play lists.
lib/const/agents.dart Makes Fade’s Haunt radius visible by removing opacity: 0.
AGENTS.md Removes the agent/contributor instructions document.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pubspec.yaml
publish_to: "none" # Remove this line if you wish to publish to pub.dev

version: 4.3.4+88 #version number
version: 4.3.5+89 #version number
@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes two Fade visual bugs (stale icon asset and invisible scan-radius circle caused by opacity: 0), corrects the active map rotation (Ascent in, Bind out), and bumps the app to 4.3.5+89 with matching release metadata.

  • Fade fixes: removes the opacity: 0 override on the Haunt CircleAbility so the purple scan radius renders, and replaces the stale icon.webp with the updated asset.
  • Map rotation: swaps Ascent into availableMaps and Bind into outofplayMaps; all 12 MapValue entries remain covered with no duplicates.
  • Version bump: pubspec.yaml, settings.dart, and the new release/metadata/4.3.5+89.json are all consistent at build 89.

Confidence Score: 4/5

The code changes are safe to merge; the only item that warrants a second look is AGENTS.md being fully emptied.

The dart and YAML changes are small, targeted, and internally consistent — opacity removal, map swap, and version bump all match their stated intent. The one open question is AGENTS.md: all developer workflow guidance (FVM pin, build deps, code-gen steps, lint baseline) was removed with no redirect or explanation, which could silently break onboarding for future contributors and AI tooling that reads the file before making changes.

AGENTS.md — all content was removed; worth confirming the guidance was intentionally retired or moved elsewhere before merging.

Important Files Changed

Filename Overview
AGENTS.md All content removed, leaving the file empty — developer workflow instructions (FVM, build deps, code-gen, lint baseline) are gone without explanation or redirect
lib/const/agents.dart Removed the erroneous opacity: 0 override on Fade's Haunt CircleAbility; the scan radius will now render with the intended purple outline
lib/const/maps.dart Swapped Ascent into availableMaps and Bind into outofplayMaps; all 12 MapValue entries remain accounted for with no duplicates
lib/const/settings.dart Version bumped to 4.3.5 / build 89, consistent with pubspec.yaml
pubspec.yaml Version string and msix_version updated to 4.3.5+89 / 4.3.5.0, matching settings.dart
release/metadata/4.3.5+89.json New release metadata file; version, shortVersion, channels, and changelog entries all look correct

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Fade AgentData] --> B[abilities[1] CircleAbility\nsize: 6.58, opacity: null]
    A --> C[abilities[2] CircleAbility\nsize: 30, opacity: null\n✅ was opacity:0]
    A --> D[abilities.last SquareAbility]

    E[Maps.availableMaps] --> F[ascent ✅ was bind]
    E --> G[haven, pearl, split,\nbreeze, lotus, fracture]

    H[Maps.outofplayMaps] --> I[bind ✅ was ascent]
    H --> J[sunset, abyss,\nicebox, corrode]
Loading

Comments Outside Diff (1)

  1. AGENTS.md, line 1 (link)

    P2 AGENTS.md fully emptied without explanation

    This file previously held the canonical onboarding and workflow reference for every contributor and AI coding agent touching this repo — FVM pin, xdg-user-dirs requirement, Linux build dependencies, code-generation steps, expected lint baseline, and the build path. All of that context is now gone. If the content was intentionally moved elsewhere (e.g., README.md) it would be worth adding a note or at minimum calling it out in the PR description, since the custom rule for this repo explicitly points AI tools here for guidance before making changes.

    Context Used: AGENTS.md (source)

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (1): Last reviewed commit: "Remove stale AGENTS instructions" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants