[FEAT] iOS FCM 푸시 알림 지원 추가#364
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
WalkthroughiOS 플랫폼 타입을 추가하고, Feed 및 Room FCM 알림 메시지에 APNs 설정과 기본 사운드를 적용했습니다. 토큰 등록 API 문서에도 IOS 지원 값이 반영되었습니다. ChangesiOS FCM 알림
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant FeedNotificationDispatchService
participant RoomNotificationDispatchService
participant FirebaseCloudMessaging
participant IOSDevice
FeedNotificationDispatchService->>FirebaseCloudMessaging: APNs 설정이 포함된 FCM Message 발송
RoomNotificationDispatchService->>FirebaseCloudMessaging: APNs 설정이 포함된 FCM Message 발송
FirebaseCloudMessaging->>IOSDevice: 기본 사운드가 설정된 iOS 알림 전달
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Test Results488 tests 488 ✅ 45s ⏱️ Results for commit 9c6a449. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
PlatformType에IOS추가ApnsConfig(sound: default)적용하여 iOS 알림 소리 지원ApnsConfig무시하므로 분기 처리 불필요📸 스크린샷
💬 리뷰 요구사항
📌 PR 진행 시 이러한 점들을 참고해 주세요
Summary by CodeRabbit
새로운 기능
문서