Skip to content

issues#7849

Open
schiller-manuel wants to merge 1 commit into
fix-router-core-lane-match-loaderfrom
issues-rewrite
Open

issues#7849
schiller-manuel wants to merge 1 commit into
fix-router-core-lane-match-loaderfrom
issues-rewrite

Conversation

@schiller-manuel

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b1740b31-a514-4b49-b2c0-9e8d953fe2ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issues-rewrite

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit b1c8ed7

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 13m 25s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 16s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 15:37:39 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: a87697ceb2bd
  • Measured at: 2026-07-18T15:25:32.697Z
  • Baseline source: history:62a191baa068
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 87.13 KiB -223 B (-0.25%) 86.99 KiB 270.88 KiB 75.77 KiB ███▇▇▇▇▇▇▇▇▁
react-router.full 90.84 KiB -230 B (-0.25%) 90.70 KiB 282.78 KiB 79.06 KiB ███▇▇▇▇▇▇▇▇▁
solid-router.minimal 35.11 KiB -430 B (-1.18%) 34.98 KiB 102.14 KiB 31.59 KiB ███▇▇▇▇▇▇▇▇▁
solid-router.full 40.12 KiB -478 B (-1.15%) 39.99 KiB 117.20 KiB 36.10 KiB ███████████▁
vue-router.minimal 52.40 KiB -610 B (-1.12%) 52.27 KiB 145.58 KiB 47.17 KiB ███▇▇▇▇▇▇▇▇▁
vue-router.full 58.36 KiB -595 B (-0.99%) 58.23 KiB 164.34 KiB 52.37 KiB ███▇▇▇▇▇▇▇▇▁
react-start.minimal 101.63 KiB -365 B (-0.35%) 101.49 KiB 318.80 KiB 87.90 KiB ███▇▇▇▇▇▇▇▇▁
react-start.deferred-hydration 102.37 KiB -365 B (-0.35%) 101.52 KiB 320.18 KiB 88.60 KiB ███▇▇▇▇▇▇▇▇▁
react-start.full 105.03 KiB -344 B (-0.32%) 104.89 KiB 328.73 KiB 90.85 KiB ███▇▇▇▇▇▇▇▇▁
react-start.rsbuild.minimal 99.42 KiB -264 B (-0.26%) 99.25 KiB 313.34 KiB 85.62 KiB ███▇▇▇▇▇▇▇▇▁
react-start.rsbuild.minimal-iife 99.83 KiB -258 B (-0.25%) 99.66 KiB 314.28 KiB 85.96 KiB ███▇▇▇▇▇▇▇▇▁
react-start.rsbuild.full 102.66 KiB -238 B (-0.23%) 102.49 KiB 323.40 KiB 88.36 KiB ███▆▆▆▆▆▆▆▆▁
solid-start.minimal 48.99 KiB -637 B (-1.25%) 48.85 KiB 147.80 KiB 43.28 KiB ███▇▇▇▇▇▇▇▇▁
solid-start.deferred-hydration 52.25 KiB -636 B (-1.17%) 48.91 KiB 155.84 KiB 46.29 KiB ███▇▇▇▇▇▇▇▇▁
solid-start.full 54.83 KiB -605 B (-1.07%) 54.70 KiB 164.70 KiB 48.33 KiB ███▇▇▇▇▇▇▇▇▁
vue-start.minimal 70.31 KiB -740 B (-1.02%) 70.18 KiB 202.34 KiB 62.34 KiB ███▇▇▇▇▇▇▇▇▁
vue-start.full 74.30 KiB -752 B (-0.98%) 74.17 KiB 214.97 KiB 65.70 KiB ███▇▇▇▇▇▇▇▇▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7849

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7849

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7849

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7849

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7849

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7849

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7849

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7849

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7849

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7849

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7849

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7849

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7849

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7849

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7849

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7849

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7849

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7849

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7849

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7849

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7849

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7849

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7849

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7849

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7849

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7849

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7849

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7849

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7849

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7849

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7849

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7849

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7849

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7849

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7849

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7849

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7849

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7849

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7849

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7849

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7849

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7849

commit: b1c8ed7

@codspeed-hq

codspeed-hq Bot commented Jul 18, 2026

Copy link
Copy Markdown

Merging this PR will regress 8 benchmarks

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 7 improved benchmarks
❌ 8 regressed benchmarks
✅ 165 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory mem server error-paths unmatched (react) 298.4 KB 415.8 KB -28.22%
Simulation ssr server-fn POST (solid) 62.8 ms 72.4 ms -13.3%
Simulation ssr server-fn not-found (solid) 60.9 ms 69.6 ms -12.42%
Simulation ssr server-fn send-context (solid) 64.1 ms 70.7 ms -9.33%
Simulation ssr server-fn redirect (solid) 53.5 ms 57.4 ms -6.68%
Simulation ssr server-fn GET (solid) 68.4 ms 73.2 ms -6.56%
Memory mem server error-paths redirect (solid) 290.6 KB 301.5 KB -3.6%
Simulation ssr assets linked-css control (react) 49.7 ms 51.3 ms -3.27%
Memory mem server server-fn-churn (vue) 4,319.7 KB 268.3 KB ×16
Memory mem server error-paths unmatched (vue) 2,474.2 KB 477.9 KB ×5.2
Memory mem server peak-large-page (react) 2,064.6 KB 944.5 KB ×2.2
Memory mem server error-paths redirect (vue) 436.7 KB 290.4 KB +50.36%
Memory mem server peak-large-page (solid) 946.7 KB 781.4 KB +21.14%
Memory mem server error-paths not-found (solid) 1,103.5 KB 966.4 KB +14.18%
Simulation ssr global-mw server-fn (solid) 59.3 ms 57.4 ms +3.37%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing issues-rewrite (b1c8ed7) with fix-router-core-lane-match-loader (3d68db6)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant