Temporarily move from Bcrypt to Bcryptjs for centos6 compatibility#8
Open
bdickason wants to merge 2 commits into
Open
Temporarily move from Bcrypt to Bcryptjs for centos6 compatibility#8bdickason wants to merge 2 commits into
bdickason wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aziz's server doesn't have g++ 4.9 (which is a dependency for bcrypt).
I've switched us to bcryptjs which is slower but has no dependencies so the app will build on our server.
I'm not sure how fast it is, so we should revisit this in the future once we're past launch.
More detail: kelektiv/node.bcrypt.js#476 (comment)