Introduce build_support#4
Open
crystall1nedev wants to merge 4 commits into
Open
Conversation
This is a big commit. - Work around universal2 issues by downloading or creating universal2 .whls at build time - Currently no switch to turn this off, I'll do it soon. - Re-enable universal2 in the spec (even though it's unused currently) - Backbone for future build.py refactoring by Stella since build_support exists now?
- Pass --universal2 to build a Universal binary for Intel-based Macs and Macs with Apple silicon. - Pass --skipmerge to skip the built-in preparation step for universal2. Useful if you don't want to repeatedly download the same packages or spend cycles remerging them.
Makes things a bit cleaner for the main build.py script.
- {os}_prep to be used for any pre-build preparations needing to be done
- {os}_build to be used for any building actions and checking
- main to be stubbed to tell the user not to directly call them
WINDOWS REFACTOR CURRENTLY UNTESTED
Author
|
All tasks implemented. Making sure the Windows refactor actually works before giving the green. |
Author
|
Good to merge, tested it. |
Owner
|
you smell |
Author
|
i mean probably idk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the "other changes". Fixes universal2 builds of #1.
Additionally creates a backbone for future refactoring or modularizing of PyWemoGUI's
build.py.TODO for merge:
build.pytobuild_support/macosx.pyNOTE: This will be my first and final PR to this repository on GitHub. As described elsewhere and discussed (physically) with you, future work from me on PyWemoGUI will be @ The Enclave.