Skip to content

Update metrics to fix one sink on cluster#4262

Merged
maliberty merged 24 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update-metrics-to-fix-one-sink-cluster
Jun 12, 2026
Merged

Update metrics to fix one sink on cluster#4262
maliberty merged 24 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update-metrics-to-fix-one-sink-cluster

Conversation

@luis201420

@luis201420 luis201420 commented May 27, 2026

Copy link
Copy Markdown
Contributor

Metric updates in the following designs:

  • ng45/ariane133
Metric Old New Type
cts__timing__setup__tns -480.0 -491.0 Failing
finish__timing__setup__tns -585.0 -593.0 Failing
  • ng45/bp_be_top
Metric Old New Type
globalroute__timing__setup__tns -19.3 -20.1 Failing
finish__timing__setup__tns -20.0 -21.1 Failing
  • ng45/mempool_group
Metric Old New Type
cts__timing__setup__tns -12000.0 -12200.0 Failing
globalroute__timing__setup__tns -13900.0 -12100.0 Tighten
finish__timing__hold__tns -0.6 -1.35 Failing
  • sky130hd/microwatt
Metric Old New Type
finish__timing__hold__tns -5.94 -9.71 Failing

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
…sink-cluster

Signed-off-by: luis201420 <luisemv@precisioninno.com>
…sink-cluster

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
@luis201420 luis201420 self-assigned this May 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the baseline timing, antenna, and design rules in rules-base.json across multiple designs, including ariane133, bp_fe_top, mempool_group, swerv_wrapper, and microwatt. The changes adjust various threshold values for setup/hold worst slack (WS), total negative slack (TNS), and antenna diode counts to reflect updated design constraints. I have no feedback to provide as there are no review comments to address.

…sink-cluster

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
@maliberty

Copy link
Copy Markdown
Member

conflicts to resolve

…sink-cluster

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
…sink-cluster

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
@maliberty maliberty merged commit cddf870 into The-OpenROAD-Project:master Jun 12, 2026
8 checks passed
@maliberty maliberty deleted the update-metrics-to-fix-one-sink-cluster branch June 12, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants