pdn: throw error on missing grid when adding components instead of silent pass#10643
Open
gadfort wants to merge 2 commits into
Open
pdn: throw error on missing grid when adding components instead of silent pass#10643gadfort wants to merge 2 commits into
gadfort wants to merge 2 commits into
Conversation
…lent pass Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces dummy instance grids to handle cases where no instances are found for a macro grid definition, preventing hard failures and instead issuing a warning. Key changes include the addition of the DummyInstanceGrid class, updates to grid retrieval and lookup methods to support dummy grids, and integration into the Tcl grid definition flow. Two critical issues were identified in the Tcl implementation: an invalid empty command evaluation [] used for list initialization, and a SWIG type mismatch caused by passing a list of domains instead of iterating over them individually.
Signed-off-by: Peter Gadfort <gadfort@zeroasic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensures the power grid definition will generate an error when an undefined grid is referenced. This avoids nasty PDN errors when typos appear in the grid component commands and there is no error.
Type of Change
Impact
For most users a warning will appear when a unused grid is created, but unless they have setup errors, there should be no change to the final result.
Verification
./etc/Build.sh).