Skip to content

Fix split validation for invalid separators#14720

Closed
miaomiao0319 wants to merge 2 commits into
TheAlgorithms:masterfrom
miaomiao0319:fix-split-multi-character-separator
Closed

Fix split validation for invalid separators#14720
miaomiao0319 wants to merge 2 commits into
TheAlgorithms:masterfrom
miaomiao0319:fix-split-multi-character-separator

Conversation

@miaomiao0319
Copy link
Copy Markdown

This PR fixes the behavior of strings/split.py when an invalid separator is provided.

Changes:

  • Add validation for empty separators.
  • Add validation for multi-character separators.
  • Add doctest examples for invalid separators.

Fixes #14649

Copilot AI review requested due to automatic review settings May 26, 2026 04:25
@algorithms-keeper
Copy link
Copy Markdown

Closing this pull request as invalid

@miaomiao0319, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added invalid awaiting reviews This PR is ready to be reviewed labels May 26, 2026
@algorithms-keeper algorithms-keeper Bot review requested due to automatic review settings May 26, 2026 04:26
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split silently returns wrong result for multi-character separators

1 participant