Skip to content

fix: add input validation to cyclic_sort to prevent infinite loop #14962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deepshekhardas wants to merge 1 commit into from
Closed

fix: add input validation to cyclic_sort to prevent infinite loop #14962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions sorts/cyclic_sort.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ def cyclic_sort(nums: list[int]) -> list[int]:

:param nums: List of n integers from 1 to n to be sorted.
:return: The same list sorted in ascending order.
:raises ValueError: If nums contains non-integer or negative values.

Time complexity: O(n), where n is the number of integers in the list.

Expand All @@ -27,8 +28,15 @@ def cyclic_sort(nums: list[int]) -> list[int]:
[]
>>> cyclic_sort([3, 5, 2, 1, 4])
[1, 2, 3, 4, 5]
>>> cyclic_sort([3, 5, -2, 1, 4])
Traceback (most recent call last):
...
ValueError: All values must be positive integers
"""

if any(not isinstance(x, int) or x <= 0 for x in nums):
raise ValueError("All values must be positive integers")

# Perform cyclic sort
index = 0
while index < len(nums):
Expand Down