New better timetable example from Slovenia

[atibaut]

This example of a timetable replaces the file Netex_09.2_Bus_SimpleTimetable_Slovenia.xml. The timetable was created from a national NeTEx service in Slovenia (Ministry of Transport/NCUP).

[Aurige]

fine for me, but maybe put if in NeTEx\examples\standards\slovenia rather than in NeTEx\examples\functions\timetable ?

[skinkie]

@atibaut my suggestion would be to change pos to posList. That would already save a considerable amount of data.
I notice the namespace "p10:" please define this at the top level of the document als gml:

                           <LineString
                                p10:id="SI_SI0_LineStringType_00000000-1177-000a-0011-236e001135bb_IJPP"
                                xmlns:p10="http://www.opengis.net/gml/3.2"
                                xmlns="http://www.opengis.net/gml/3.2">

I notice that ScheduledStopPointRef, ServiceLinkRef, OperatingDayRef, DayTypeRef all lack the version attribute, that this is not being picked up, is a bug in the XML Schema.

                                <StopPointInJourneyPattern
                                    id="SI:SI0:StopPointInJourneyPattern:00000000-1177-0009-0000-000000725b39:IJPP"
                                    created="2023-10-06T04:51:58.9174842Z" version="1" order="7">
                                    <ScheduledStopPointRef
                                        ref="SI:SI0:ScheduledStopPoint:00000000-1177-0003-0000-00000011258e:IJPP"
                                    />

                                <ServiceLinkInJourneyPattern
                                    id="SI:SI0:ServiceLinkInJourneyPattern:00000000-1177-0009-0072-5b4100725b40:IJPP"
                                    created="2023-10-06T04:51:58.9174842Z" version="1" order="14">
                                    <ServiceLinkRef
                                        ref="SI:SI0:ServiceLink:00000000-1177-0003-0011-372900113744:IJPP"
                                    /> 
                                </ServiceLinkInJourneyPattern>

                        <DayTypeAssignment
                            id="SI:SI0:DayTypeAssignment:00000000-1177-0005-0000-062400010e54:IJPP"
                            created="2023-10-26T08:11:03.7694927Z" version="2" order="345">
                            <OperatingDayRef
                                ref="SI:SI0:OperatingDay:00000000-1177-0005-0000-01b70000594d:IJPP"/>
                            <DayTypeRef version="1"
                                ref="SI:SI0:DayType:00000000-1177-0004-0000-06240000065e:IJPP"/>
                        </DayTypeAssignment>

[nick-knowles]

This is not true the attribute is present but optional. because you may choose to have versionRef or version defepending on whether it is an internal or external ref.

[ue71603]

@atibaut pls update the PR

[atibaut]

It is never too late to improve a NeTEx timetable example. 😀

PR updated and rebased onto v2.0 (base retargeted from v1.3):

• Moved to examples/standards/slovenia/ as suggested by @Aurige.
• As suggested by @skinkie, the repeated per-LineString p10:/default namespace declarations are gone, and gml: is now declared once on the root element, and the ~2 700 individual gml:pos points are merged into one gml:posList per LineString (with srsName, srsDimension and count); the file shrank from 12376 to 9591 lines.
• File extension lowercased to .xml, and the CI validation script's find -name "*.xml" is case-sensitive and would have skipped the uppercase .XML.
• xsi:schemaLocation now uses the conventional relative path instead of an absolute local path.

Validated against NeTEx_publication.xsd on current v2.0 with xmllint.

Note: the original Netex_09.2_Bus_SimpleTimetable_Slovenia.xml teaching example is left in place, since this file now lives under examples/standards/ as a real-world NAP export rather than replacing the simple functional example.

[atibaut]

@skinkie @TuThoThai the updated example is ready for your review.

[atibaut]

Hi @TuThoThai can someone look at this. 😀

[TuThoThai]

@atibaut, I am moving the base branch to v2.1-wip since it is not a bug-fix. 😄

The base branch was changed.

[TuThoThai]

@atibaut, I made some comments in the file. Please note that for some comments, e.g. the position of version, my comments are only in the first occurrence and not in everyone of them.

[TuThoThai]

@atibaut, please note that PrivateCode has been depcreated since v2.0 in favour of privateCodes in DataManagedGroup

[TuThoThai]

@atibaut, in all the pointsInSequence, could you please remove order as it was deprecated in favour of XML ordering?

[TuThoThai]

@atibaut, for all the StopPointInJourneyPatternRef, could we have version at the end to be consistent in the file?

[TuThoThai]

@atibaut, I believe that in this file all your ScheduledStopPoint are associated with a Quay via PassengerStopAssignment. So, name could be removed as redundant