feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14#77
Open
mstyura wants to merge 1 commit into
Open
feat: widen tonic dependency to >=0.13, <0.15 to support tonic 0.14#77mstyura wants to merge 1 commit into
mstyura wants to merge 1 commit into
Conversation
|
Any thoughts here @skos-ninja ? Happy to help with testing if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support tonic 0.14 alongside 0.13
Addresses #68: Widens
ginepro'stonicrequirement to>=0.13, <0.15so downstream users can build against either 0.13 or 0.14.Changes
ginepro: widentonicto>=0.13, <0.15and drop theprostfeature (removed in 0.14; ginepro never used the prost codec, so it's a no-op on 0.13).shared_proto/tests: move to tonic 0.14, which splits prost codegen into separate crates (tonic-build->tonic-prost-build, plustonic-prost).tonic-0_13-checkjob that compilesgineproagainst the 0.13 lower bound, so both ends of the range are covered (0.14 via the existing test suite, 0.13 via this check).Verification
cargo check --workspace --all-featurespasses on 0.14.gineprocompiles clean against tonic 0.13.1 with bothtls-ringandtls-aws-lc.