feat(watch): pass --filter through to watch loop#688
Merged
Conversation
bashunit::main::cmd_watch now parses its arguments so the path can appear in any position and -f/--filter (with its value) plus other flags are forwarded to each underlying test run. Also fixes a quoting bug that passed extra args with literal escaped quotes. Bash 3.0+ compatible. Closes #682
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #682
bashunit watchre-ran everything on each change and mishandled forwarded flags, so--filtercould not be used to narrow the watch loop.💡 Changes
watcharguments so the path can appear in any position-f/--filter(and its value) plus other flags to each underlying test run