fix(test): make _supports_wait_n test set -e safe#691
Merged
Conversation
On Bash < 4.3 bashunit::runner::_supports_wait_n returns 1; called as a bare statement under --strict (set -euo pipefail) it aborted the test body, which cascaded into the rest of parallel_test.sh erroring. Capture the rc with '|| actual_rc=$?' instead. Only surfaced on Bash 3.x, which CI never exercises under --strict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Running
./bashunit -s -p --stricton Bash 3.x reported a failure: 21 of 23 tests inparallel_test.sherrored.💡 Changes
test_supports_wait_n_matches_running_bash_versioncalledbashunit::runner::_supports_wait_nas a bare statement; on Bash < 4.3 it returns 1, so underset -euo pipefailthe test body aborted and cascaded into the rest of the file|| actual_rc=$?so--strictno longer aborts