test(coverage): skip subshell-tracking tests on macOS#693
Merged
Conversation
The DEBUG-trap + set -T recorder does not propagate into subshells on the macOS system Bash (3.2), so these edge-case tests recorded 0 hits and failed locally on macOS while passing on Linux for all supported Bash. Skip them on Darwin (matching the existing Git Bash skip) and rename the guard to _skip_when_unsupported_context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
coverage_subshell_test.shfailed when run on the macOS system Bash (3.2): the DEBUG-trap +set -Trecorder does not propagate into subshells there, so it recorded 0 hits. The same tests pass on Linux for all supported Bash versions.💡 Changes
Darwin*(matching the existing Git Bash skip)_skip_when_unsupported_context