Skip to content

Fix system language selection for locale aliases - #649

Open
CoffeeFlux wants to merge 2 commits into
TypesettingTools:masterfrom
CoffeeFlux:fix/issue-211-language-selection
Open

Fix system language selection for locale aliases#649
CoffeeFlux wants to merge 2 commits into
TypesettingTools:masterfrom
CoffeeFlux:fix/issue-211-language-selection

Conversation

@CoffeeFlux

Copy link
Copy Markdown
Member

Fixes #211

@CoffeeFlux
CoffeeFlux marked this pull request as ready for review August 1, 2026 00:57
@CoffeeFlux
CoffeeFlux requested a review from arch1t3cht August 1, 2026 00:59
@arch1t3cht

Copy link
Copy Markdown
Member

As far as I can tell, this does not actually fix #211: The setup I tested had wxLocale::GetLanguageInfo(wxLocale::GetSystemLanguage())->CanonicalName returning tr_TR (hence wxLocale::GetSystemLanguage() being wxLANGUAGE_TURKISH_TURKIYE = 821) while the translation language was tr (info->Language being wxLANGUAGE_TURKISH = 819). So these differ both in CanonicalName and in Language.

AFAICT wxWidgets does not give too much information about how various languages are related but maybe additionally comparing the translation's CanonicalRef to the system language would work better? But, also, see #211 (comment) - it's quite possible that this issue is no longer as relevant as before.

@0tkl

0tkl commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

FYI, it works for ko-KR

화면 캡처 2026-08-07 115413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GetLanguageInfo()->CanonicalName not as expected

3 participants