ci: Harden workflows#1397
Open
RandomByte wants to merge 1 commit into
Open
Conversation
matz3
reviewed
May 26, 2026
| steps: | ||
| - uses: actions/checkout@v6 | ||
| with: | ||
| persist-credentials: false |
Member
There was a problem hiding this comment.
Not needed as job does not have write permissions anyways, right?
- Scope release-please contents/pull-requests write permissions to the release-please job; publish jobs only need id-token: write - Disable persist-credentials on checkouts that don't push to git - Move repository.name interpolation into env var to avoid template injection in run blocks - Replace spoofable github.actor check in dependabot-auto-merge with github.event.pull_request.user.login. Note: spoofing the dependabot actor alone is not sufficient to trigger the auto-merge step. The dependabot/fetch-metadata action only emits outputs for genuine dependabot PRs, so the merge step's check on steps.metadata.outputs.update-type would no-op on a spoofed run. The change closes the gap defensively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
release-please job; publish jobs only need id-token: write
injection in run blocks
github.event.pull_request.user.login. Note: spoofing the dependabot
actor alone is not sufficient to trigger the auto-merge step. The
dependabot/fetch-metadata action only emits outputs for genuine
dependabot PRs, so the merge step's check on
steps.metadata.outputs.update-type would no-op on a spoofed run. The
change closes the gap defensively.