remove unused Werkzeug dependency pin - #61
Open
chishiki wants to merge 1 commit into
Open
Conversation
Werkzeug is never imported by uw_saml2 or its tests, cachelib is the package's actual cache dependency. The stale `Werkzeug = "^2.0.2"` pin (which resolves to <3.0.0) forces pip's resolver to fall back to uw-saml 1.0.20 in any project that also needs Flask 3.x / Werkzeug 3.x, since newer uw-saml releases can't otherwise be selected. Also update the README's replay-cache example, which referenced werkzeug.contrib.cache.RedisCache(), removed from Werkzeug in 1.0 (2019), with the equivalent cachelib.RedisCache(), the package this project already depends on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description:
Removes the unused Werkzeug = "^2.0.2" direct dependency from pyproject.toml. uw_saml2 never imports Werkzeug, cachelib is the package's actual cache dependency, but this stale pin (<3.0.0) forces pip's resolver to fall back to uw-saml==1.0.20 (June 2021) in any project that also needs Flask 3.x / Werkzeug 3.x, since no version of uw-saml since 1.1.0 can otherwise be selected alongside Werkzeug ≥3.0.
Also updates the README's replay-cache example, which called werkzeug.contrib.cache.RedisCache(), an API removed from Werkzeug in 1.0 (2019), to use cachelib.RedisCache() instead, which is both current and already a real dependency of this package.
Testing performed:
Pull Request checklist
./scripts/pre-push.shsemver-guidance:label for this pull request