Skip to content

Cryptography: move cryptography property metadata to ViewModels and align category visibility defaults [STUD-80610]#583

Merged
viogroza merged 1 commit into
developfrom
fix/stud-80610_crypto_problems
Jun 26, 2026
Merged

Cryptography: move cryptography property metadata to ViewModels and align category visibility defaults [STUD-80610]#583
viogroza merged 1 commit into
developfrom
fix/stud-80610_crypto_problems

Conversation

@viogroza

Copy link
Copy Markdown
Collaborator

DecryptCryptoViewModelBase
EncryptCryptoViewModelBase
DecryptFileViewModel
DecryptTextViewModel
EncryptFileViewModel
EncryptTextViewModel
KeyedHashFileViewModel
KeyedHashTextViewModel
PgpGenerateKeysViewModel
PgpSignViewModelBase
PgpSignFileViewModel
PgpClearSignFileViewModel
PgpVerifyViewModel
ViewModelPropertyMetadataHelper
generated by GitHub Copilot

Addresses the below item - root cause was that there were different info in the viewmodel vs metadata info)
Kept the info only in the view model
https://uipath.atlassian.net/browse/STUD-80610

…lign category visibility defaults [STUD-80610]

DecryptCryptoViewModelBase
EncryptCryptoViewModelBase
DecryptFileViewModel
DecryptTextViewModel
EncryptFileViewModel
EncryptTextViewModel
KeyedHashFileViewModel
KeyedHashTextViewModel
PgpGenerateKeysViewModel
PgpSignViewModelBase
PgpSignFileViewModel
PgpClearSignFileViewModel
PgpVerifyViewModel
ViewModelPropertyMetadataHelper
generated by GitHub Copilot
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1.0% Coverage on New Code (required ≥ 80%)
7.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates Cryptography activity property metadata by removing property definitions from ActivitiesMetadata.json and instead configuring required/principal/visibility/category plus display name + tooltip directly in the corresponding NetCore ViewModels, to eliminate drift between metadata sources (per STUD-80610).

Changes:

  • Cleared per-activity Properties blocks in Cryptography’s ActivitiesMetadata.json (now Properties: []), making the ViewModels the single source of truth for property metadata.
  • Updated multiple ViewModels to explicitly set IsRequired, IsPrincipal, IsVisible, and Category to match the prior metadata intent (notably Options-vs-Input categorization).
  • Added ConfigurePropertyTexts() methods across ViewModels to set DisplayName/Tooltip from Resources.* keys.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Activities/Cryptography/UiPath.Cryptography.Activities/Resources/ActivitiesMetadata.json Removes property metadata entries (now empty arrays) so property metadata is driven from ViewModels.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpVerifyViewModel.cs Aligns required/visible defaults and adds centralized property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpSignViewModelBase.cs Aligns required/visible/category defaults; introduces ConfigurePropertyTexts() contract for derived ViewModels.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpSignFileViewModel.cs Implements property text configuration for PGP Sign File properties.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpGenerateKeysViewModel.cs Aligns required flags for passphrase inputs and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpClearSignFileViewModel.cs Implements property text configuration for PGP Clear Sign File properties.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/KeyedHashTextViewModel.cs Aligns required/principal/category defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/KeyedHashFileViewModel.cs Aligns required/principal/category defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptTextViewModel.cs Aligns argument naming/required defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptFileViewModel.cs Aligns options categorization/principal defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptCryptoViewModelBase.cs Aligns required/category defaults for shared encrypt properties (incl. key encoding + deprecated warning).
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptTextViewModel.cs Aligns required defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptFileViewModel.cs Aligns options categorization/principal defaults and adds property DisplayName/Tooltip configuration.
Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptCryptoViewModelBase.cs Aligns required/category defaults for shared decrypt properties (incl. key encoding + verify signature).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucarachiteanu lucarachiteanu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viogroza viogroza merged commit e1436d4 into develop Jun 26, 2026
9 of 10 checks passed
@viogroza viogroza deleted the fix/stud-80610_crypto_problems branch June 26, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants