Cryptography: move cryptography property metadata to ViewModels and align category visibility defaults [STUD-80610]#583
Merged
Conversation
…lign category visibility defaults [STUD-80610] DecryptCryptoViewModelBase EncryptCryptoViewModelBase DecryptFileViewModel DecryptTextViewModel EncryptFileViewModel EncryptTextViewModel KeyedHashFileViewModel KeyedHashTextViewModel PgpGenerateKeysViewModel PgpSignViewModelBase PgpSignFileViewModel PgpClearSignFileViewModel PgpVerifyViewModel ViewModelPropertyMetadataHelper generated by GitHub Copilot
|
There was a problem hiding this comment.
Pull request overview
This PR consolidates Cryptography activity property metadata by removing property definitions from ActivitiesMetadata.json and instead configuring required/principal/visibility/category plus display name + tooltip directly in the corresponding NetCore ViewModels, to eliminate drift between metadata sources (per STUD-80610).
Changes:
- Cleared per-activity
Propertiesblocks in Cryptography’sActivitiesMetadata.json(nowProperties: []), making the ViewModels the single source of truth for property metadata. - Updated multiple ViewModels to explicitly set
IsRequired,IsPrincipal,IsVisible, andCategoryto match the prior metadata intent (notably Options-vs-Input categorization). - Added
ConfigurePropertyTexts()methods across ViewModels to setDisplayName/TooltipfromResources.*keys.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Activities/Cryptography/UiPath.Cryptography.Activities/Resources/ActivitiesMetadata.json | Removes property metadata entries (now empty arrays) so property metadata is driven from ViewModels. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpVerifyViewModel.cs | Aligns required/visible defaults and adds centralized property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpSignViewModelBase.cs | Aligns required/visible/category defaults; introduces ConfigurePropertyTexts() contract for derived ViewModels. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpSignFileViewModel.cs | Implements property text configuration for PGP Sign File properties. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpGenerateKeysViewModel.cs | Aligns required flags for passphrase inputs and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/PgpClearSignFileViewModel.cs | Implements property text configuration for PGP Clear Sign File properties. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/KeyedHashTextViewModel.cs | Aligns required/principal/category defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/KeyedHashFileViewModel.cs | Aligns required/principal/category defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptTextViewModel.cs | Aligns argument naming/required defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptFileViewModel.cs | Aligns options categorization/principal defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/EncryptCryptoViewModelBase.cs | Aligns required/category defaults for shared encrypt properties (incl. key encoding + deprecated warning). |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptTextViewModel.cs | Aligns required defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptFileViewModel.cs | Aligns options categorization/principal defaults and adds property DisplayName/Tooltip configuration. |
| Activities/Cryptography/UiPath.Cryptography.Activities/NetCore/ViewModels/DecryptCryptoViewModelBase.cs | Aligns required/category defaults for shared decrypt properties (incl. key encoding + verify signature). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


DecryptCryptoViewModelBase
EncryptCryptoViewModelBase
DecryptFileViewModel
DecryptTextViewModel
EncryptFileViewModel
EncryptTextViewModel
KeyedHashFileViewModel
KeyedHashTextViewModel
PgpGenerateKeysViewModel
PgpSignViewModelBase
PgpSignFileViewModel
PgpClearSignFileViewModel
PgpVerifyViewModel
ViewModelPropertyMetadataHelper
generated by GitHub Copilot
Addresses the below item - root cause was that there were different info in the viewmodel vs metadata info)
Kept the info only in the view model
https://uipath.atlassian.net/browse/STUD-80610