fix: spawn disabled in scene placed and network prefab registration by NoelStephensUnity · Pull Request #4093 · Unity-Technologies/com.unity.netcode.gameobjects

NoelStephensUnity · 2026-07-21T19:07:11Z

Purpose of this PR

This is a continuation of the fixes for the initial spawn sequence on the session owner/server side.
This PR includes:

A fix for not being able to spawn an in-scene placed NetworkObject if it is initially disabled in the scene.
A fix for not allowing users to spawn dynamically generated NetworkObjects during runtime where the NetworkObject.GlobalObjectIdHash is zero.
Some potential edge case exceptions.
Overhauled several integration tests that were not properly creating network prefabs.

Jira ticket

NA

Changelog

Fixed: issue with not being able to spawn initially disabled in-scene placed objects.
Fixed: issue with pre-instantiated network prefab instances being marked as in-scene placed. Now pre-instantiated network prefabs are dynamically spawned.
Fixed: issue where a user could spawn runtime created NetworkObject that has a GlobalObjectIdHash of zero. These are not valid instances and will no longer be allowed to spawn.

Documentation

Documentation changes are necessary.
- In-scene placed NetworkObjects section was updated to include pre-disabled in-scene placed NetworkObjects.
- NetworkObject section was updated to provide a high-level overview of what is and is not a valid NetworkObject.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

Manual testing done
- NGO Examples scene troubleshooting

Automated tests:

Covered by existing automated tests
Covered by new automated tests

Does the change require QA team to:

Review automated tests?
Execute manual tests?
Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Up-port

Up-port is required.

Backports

No back port is required.

- Issue where disabled in-scene placed NetworkObjects could not be spawned after starting a session. - Issue where users are allowed to spawn a NetworkObject with a GlobalObjectIdHash value of 0 (zero).

NetworkAnimator not pointing to an animator within awake now just logs a warning as opposed to an error.

Updating tests based on the fixes applied to this branch. A large portion is related to some integration tests trying to spawn NetworkObjects with a GlobalObjectIdHash value of zero(0).

Style and providing internal write access to the prefabs list.

Potentially last iteration on fixing/updating integration tests.

Using the fixed version of NetworkPrefabHandlerSpawnAndSynchronizeTests. Fixing some issues with prefab and handler creation.

…and-network-prefab-registration

Fixing formatting issues.

Fixing some standards formatting related issues.

removing trailing spaces.

NoelStephensUnity · 2026-07-23T17:05:40Z

            CreateServerAndClients(NumberOfClients);
        }

+        internal virtual bool ShouldCreatePlayerPrefab()


We might make this protected, but it seemed we needed a way to more easily control whether we should spawn the player prefab or not.

Super weird one... but using ? as opposed to an if null check.

Removing commented out code that is no longer needed/used.

codecov-github-com · 2026-07-23T17:56:03Z

Codecov Report

Attention: Patch coverage is 75.25773% with 24 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...ameobjects/Runtime/Configuration/NetworkPrefabs.cs	84.74%	9 Missing ⚠️
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs	68.42%	6 Missing ⚠️
...tcode.gameobjects/Editor/InScenePlacedProcessor.cs	37.50%	5 Missing ⚠️
....netcode.gameobjects/Runtime/Core/NetworkObject.cs	63.63%	4 Missing ⚠️

@@                Coverage Diff                @@
##           develop-2.0.0    #4093      +/-   ##
=================================================
- Coverage          73.87%   73.83%   -0.04%     
=================================================
  Files                172      172              
  Lines              28013    28094      +81     
=================================================
+ Hits               20695    20744      +49     
- Misses              7318     7350      +32

Flag	Coverage Δ
NGOv2_project_testproject_ubuntu_pinnedTrunk	`73.62% <75.25%> (?)`
NGOv2_project_testproject_ubuntu_trunk	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
....gameobjects/Runtime/Components/NetworkAnimator.cs	`76.02% <ø> (ø)`
....netcode.gameobjects/Runtime/Core/NetworkObject.cs	`75.34% <63.63%> (+0.45%)`	⬆️
...tcode.gameobjects/Editor/InScenePlacedProcessor.cs	`75.00% <37.50%> (-12.50%)`	⬇️
...ameobjects/Runtime/Spawning/NetworkSpawnManager.cs	`73.18% <68.42%> (-0.11%)`	⬇️
...ameobjects/Runtime/Configuration/NetworkPrefabs.cs	`81.55% <84.74%> (+1.92%)`	⬆️

... and 4 files with indirect coverage changes

Components	Coverage Δ
com.unity.netcode.gameobjects	`73.83% <77.35%> (-0.04%)`	⬇️

ℹ️ Need help interpreting these results?

Committing suggested changes. Co-authored-by: Emma <emma.mcmillan@unity3d.com>

Applying changes based on review discussion.

…egistration' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/spawn-disabled-in-scene-placed-and-network-prefab-registration

Making adjustments based on review discussion.

Removing field that is no longer valid. Moving Awake higher in NetworkObject as it has become wedged in the middle of the code.

…and-network-prefab-registration

Adding change log entries.

Inverting logic (oops)

Updating NetworkObject documentation and in-scene placed documentation.

Clarified the categories of NetworkObjects and their requirements. Added details for dynamically instantiated and in-scene placed NetworkObjects.

White spaces!

Co-authored-by: Amy Reeve <amy.reeve@unity3d.com>

…and-network-prefab-registration

* chore: Adding a note about DontDestroyOnLoad usage for Networked scene objects (#4070) Docs correction * ci: Split code coverage into Package Test and Project Test jobs (#4101) * ci: Split code coverage into Package Test and Project Test jobs Convert the existing coverage job to [Code Coverage] Package Test - NGO [ubuntu, trunk] and add [Code Coverage] Project Test - NGO testproject [ubuntu, trunk]. Wire Package Test into PR/nightly triggers and Project Test into the weekly run. * ci: Run both coverage jobs on PR and nightly * ci: Use pinnedTrunk for PR coverage and drop package-test job * chore: Point CMB resources at new monorepo (#4106) * chore: Point CMB resources at new monorepo * fix: NetworkVariable change prior to ownership change using distributed authority topology fails to sync NetworkVariable (#4107) * fix This resolves the issue where in a distributed authority session changing a NetworkVariable prior to changing ownership in the same call-stack would result in the NetworkVariable not being synchronized. * fix - update Removing the additional authority check as it is not needed. Fixing a very edge case scenario that shouldn't happen but in the event it does when finding objects by type within a specific scene, if the scene is invalid then use an empty array for the found objects. * fix: spawn disabled in scene placed and network prefab registration (#4093) * fix - Issue where disabled in-scene placed NetworkObjects could not be spawned after starting a session. - Issue where users are allowed to spawn a NetworkObject with a GlobalObjectIdHash value of 0 (zero). * update NetworkAnimator not pointing to an animator within awake now just logs a warning as opposed to an error. * test Updating tests based on the fixes applied to this branch. A large portion is related to some integration tests trying to spawn NetworkObjects with a GlobalObjectIdHash value of zero(0). * update Style and providing internal write access to the prefabs list. * test Potentially last iteration on fixing/updating integration tests. * test - fix Using the fixed version of NetworkPrefabHandlerSpawnAndSynchronizeTests. Fixing some issues with prefab and handler creation. * style Fixing formatting issues. * style Fixing some standards formatting related issues. * style removing trailing spaces. * style Super weird one... but using ? as opposed to an if null check. * style Removing commented out code that is no longer needed/used. * update Committing suggested changes. Co-authored-by: Emma <emma.mcmillan@unity3d.com> * update Applying changes based on review discussion. * update Making adjustments based on review discussion. * style Removing field that is no longer valid. Moving Awake higher in NetworkObject as it has become wedged in the middle of the code. * update Adding change log entries. * update Inverting logic (oops) * doc Updating NetworkObject documentation and in-scene placed documentation. * Update documentation for the two types of NetworkObjects Clarified the categories of NetworkObjects and their requirements. Added details for dynamically instantiated and in-scene placed NetworkObjects. * style White spaces! * Apply suggestions from code review Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> * docs: Docs-wide link fixes and xref update (#4102) * Docs-wide link fixes and xref update * Typo in API docs * chore: Add NGO_EXCLUDE_HEAVY_TESTS define (#4114) Add NGO_EXCLUDE_HEAVY_TESTS --------- Co-authored-by: Nikos <nikos@unity3d.com> Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Noel Stephens <noel.stephens@unity3d.com> Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> Co-authored-by: mnachury-unity <120488254+mnachury-unity@users.noreply.github.com>

NoelStephensUnity added 7 commits July 20, 2026 12:26

fix

6289aba

- Issue where disabled in-scene placed NetworkObjects could not be spawned after starting a session. - Issue where users are allowed to spawn a NetworkObject with a GlobalObjectIdHash value of 0 (zero).

update

e70d82a

NetworkAnimator not pointing to an animator within awake now just logs a warning as opposed to an error.

test

8768263

Updating tests based on the fixes applied to this branch. A large portion is related to some integration tests trying to spawn NetworkObjects with a GlobalObjectIdHash value of zero(0).

update

9ec5725

Style and providing internal write access to the prefabs list.

test

a27cffb

Potentially last iteration on fixing/updating integration tests.

test - fix

461ca09

Using the fixed version of NetworkPrefabHandlerSpawnAndSynchronizeTests. Fixing some issues with prefab and handler creation.

Merge branch 'develop-2.0.0' into fix/spawn-disabled-in-scene-placed-…

db238f5

…and-network-prefab-registration

NoelStephensUnity marked this pull request as ready for review July 21, 2026 19:10

NoelStephensUnity requested a review from a team as a code owner July 21, 2026 19:10

NoelStephensUnity added 2 commits July 21, 2026 16:00

style

0764197

Fixing formatting issues.

style

a365363

Fixing some standards formatting related issues.