Fail fast on rejected keys and unknown models - #381
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llm_completionandllm_acompletioncaught every exception the same way:retry ten times a second apart, then return
"". A rejected key or a modelname that does not exist fails identically on all ten, so a run with a bad key
took half a minute to produce a document of empty summaries and exit 0.
They now re-raise on 401, 403 and 404. Those are misconfiguration: every later
call fails the same way, and no caller can do anything useful with the empty
string. Everything else keeps the existing retry, including an unknown status,
which is a transport failure.
400 is deliberately not in the set. It also carries
context_length_exceeded,which is a per-prompt failure on one oversized node rather than a broken setup,
and callers absorb that today. Promoting it would turn one empty summary into a
failed run.
tree_optimize.expandcaught the new exception and logged it per node, so thesame misconfiguration went quiet on the
--optimizepath. It re-raises too.Measured with an invalid key: a default run now stops in 7s and
--optimizein2.4s, both naming the 401, where before both finished with empty summaries.