fix: preserve blank rows when importing Excel files#5228
Open
biubiukam wants to merge 2 commits into
Open
Conversation
Contributor
|
@biubiukam 请在项目examples的目录下建立对应复现问题的demo进行测试:问题修复前可复现,修复可不可复现 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a
🔗 Related issue link
Closes #5227
💡 Background and solution
When an Excel worksheet starts with a blank row, ExcelJS reports the number of non-empty rows and columns separately from their last populated coordinates. The importer used those counts as loop bounds, so a valid data row after a blank row was omitted.
This change derives the import bounds from each populated row and cell coordinate, preserving blank rows and columns while retaining all data.
📝 Changelog
☑️ Self-Check before Merge
🧪 Tests