Skip to content

feat: add identity insights code snippets#252

Open
alnacle wants to merge 1 commit into
mainfrom
identity-insights
Open

feat: add identity insights code snippets#252
alnacle wants to merge 1 commit into
mainfrom
identity-insights

Conversation

@alnacle

@alnacle alnacle commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@superchilled superchilled left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed these Identity Insights Python SDK snippets against a couple of things:

These Python snippets are correct when compared against what's implemented in the SDK (in that sense the snippets should run without issue, assuming the variable values are correctly set).
When compared against the snippet specs, however, there are a couple of small discrepancies:

  • On all the Python snippets, the variable name for the number to request an insight for is IDENTITY_INSIGHTS_NUMBER, whereas in the snippet specs it is INSIGHT_NUMBER
  • For the SIM swap snippet, the Python SDK has hard-coded the value for period param and used a variable for the purpose param, whereas the equivalent snippet spec does the inverse.

@dragonmantank although these are minor discrepancies between the snippet specs and the snippets, and the snippets should still technically work regardless, I feel that we should probably fix them before merging this PR just for consistency. What do you think? (Side-note: I actually think that the variable naming of IDENTITY_INSIGHTS_NUMBER in the Python snippets is better than the naming in the snippet spec, since it is more explicit. However, we should probably stick with the snippet spec naming as the source of truth, since snippets for other SDKs may already have been implemented against those specs).

Additional notes: I haven't live tested the snippets, as I assume Alvaro will have done this when he created them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants