fix not removing views from workspace preview issues#481
Open
rpaciorek wants to merge 1 commit into
Open
Conversation
* fixed not removing closed or minimalised window
* loop and line `WayfireWorkspaceWindow *w = (WayfireWorkspaceWindow*)widget;`
caused removing fist processed overlay instead of related to a closed window
* fixed not removing closed window on not current workspace
* `windows` was cleared in `clear_box` but `overlay` child was not removed
which led to overlays being duplicated when switching workspaces
rpaciorek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WayfireWorkspaceWindow *w = (WayfireWorkspaceWindow*)widget;caused removing fist processed overlay instead of related to a closed windowwindowswas cleared inclear_boxbutoverlaychild was not removed which led to overlays being duplicated when switching workspaces