Add isActive/isPassive methods to segments (NFC)#8782
Open
aheejin wants to merge 4 commits into
Open
Conversation
Currently `DataSegment` class has `isPassive` member variable but `ElementSegment` doesn't. `DataSegment`'s `isPassive` variable is redundant anyway because we can test whether its `memory` is set, as we do for `ElementSegment`'s `table`. This removes `DataSegment::isPassive` variable, and instead adds `isPassive()` and `isActive()` methods to both classes and use them instead of things like `if (segment->table)`.
tlively
reviewed
May 27, 2026
| seg->name = name; | ||
| seg->memory = memory; | ||
| seg->isPassive = isPassive; | ||
| if (!isPassive) { |
Member
There was a problem hiding this comment.
Can we remove the isPassive parameter and just unconditionally set seg->memory = memory?
kripken
approved these changes
May 27, 2026
Member
Author
|
Hmm, I'm not sure why Windows CI is failing... https://github.com/WebAssembly/binaryen/actions/runs/26546169554/job/78198387601?pr=8782 #8783 seems to have the same problem now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
DataSegmentclass hasisPassivemember variable butElementSegmentdoesn't.DataSegment'sisPassivevariable is redundant anyway because we can test whether itsmemoryis set, as we do forElementSegment'stable.This removes
DataSegment::isPassivevariable, and instead addsisPassive()andisActive()methods to both classes and use them instead of things likeif (segment->table).This also removes
isPassiveparameter frommakeDataSegmentinBuilder.