Cleanup shared constants. NFC#8922
Merged
Merged
Conversation
sbc100
commented
Jul 21, 2026
sbc100
commented
Member
- Remove some unused shared constants.
- For constants that are only used in a single file move them there
- Be consistent about how static Names are initialized.
- Remove some unused shared constants. - For constants that are only used in a single file move them there - Be consistent about how static Names are initialized.
kripken
approved these changes
Jul 21, 2026
Member
|
Nice! Btw, if you're looking for this kind of cleanup, one thing I was wondering is if we can find dead or almost dead code in our core headers, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.