Add linter for charts#357
Open
peixian wants to merge 2 commits into
Open
Conversation
facebook-github-bot
added
the
CLA Signed
|
Contributor
|
Some of these check failures don't look right. It is also checking READMEs. |
|
eozturk1
requested changes
Feb 20, 2025
| uses: karancode/yamllint-github-action@master | ||
| with: | ||
| yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*' | ||
| yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*.yml' |
Contributor
There was a problem hiding this comment.
Yeah we need to add *.yaml here as well because almost all of our files are .yamls.
Contributor
Author
There was a problem hiding this comment.
Thinking about it more, I'm pretty sure helm charts actually fail yamllint, since the interpolation isn't yaml standard. I don't think we can use this, we'll need to do a helm lint instead per sbaudoin/yamllint#16 (comment)
Contributor
Author
There was a problem hiding this comment.
We should use https://github.com/helm/chart-testing-action instead. Although neither of these would catch the procotcl misspelling error, as there's no defined spec for it. It'd catch invalid formatting, but not invalid keys.
K91AYAM
approved these changes
Mar 14, 2025
|
Hi @peixian! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.