Add long unicode61 token search fallback - #5081
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fts_token_too_longevidence and a synchronized trigram index, then revalidate token membership before returning results.Root cause
SQLite FTS5's unicode61 tokenizer does not index tokens longer than 1,000 characters. CodeIndex already detected and reported those tokens, but search had no bounded alternate candidate path for literals contained only inside an overlong token.
Validation
dotnet build CodeIndex.sln -c Release --no-restoreDbSearchReaderIssueTestsand related diagnostics onnet8.0: 27 passedDbSearchReaderIssueTestsand related diagnostics onnet9.0: 25 passed, 2 skipped as expecteddotnet run --project tools/CodeIndex.Changelog --no-restore -- checkDocumentation and changelog
USER_GUIDE.mdandTESTING_GUIDE.md.changelog.d/unreleased/5080.fixed.md.Fixes #5080