Fix rich-text attribute type normalization in WP_Block_Type#11985
Fix rich-text attribute type normalization in WP_Block_Type#11985USERSATOSHI wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac ticket: https://core.trac.wordpress.org/ticket/61406
Block attributes with
type: "rich-text"(used inblock.jsonfor the editor) are not valid JSON Schema types. WhenWP_Block_Type::prepare_attributes_for_render()callsrest_validate_value_from_schema(), the unrecognisedrich-texttype triggers a_doing_it_wrong()notice:Changes in this PR:
src/wp-includes/class-wp-block-type.php— Inset_props(), normaliserich-texttostringat block registration time. This runs once (not per-render) and occurs before theregister_block_type_argsfilter, so plugins can still override if needed.tests/phpunit/tests/blocks/wpBlockType.php— Added arichtextattribute case totest_prepare_attributes()to verify thatrich-texttyped attributes pass validation without triggering_doing_it_wrong.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.