Skip to content

HTML API: Yield final test case#12509

Closed
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:fix/html-api-wpt-tests
Closed

HTML API: Yield final test case#12509
sirreal wants to merge 4 commits into
WordPress:trunkfrom
sirreal:fix/html-api-wpt-tests

Conversation

@sirreal

@sirreal sirreal commented Jul 13, 2026

Copy link
Copy Markdown
Member

The web-platform-tests test suite for the HTML API (previously html5lib-tests) used return for the final case, which is not reached by iteration. The final test case in each test file was never run.

Diff with trunk: ./vendor/bin/phpunit --group=html-api-web-platform-tests

-Tests: 1655, Assertions: 1221, Skipped: 434.
+Tests: 1707, Assertions: 1261, Failures: 1, Skipped: 446.

The failure is due to web-platform-tests/wpt#61257 (an incorrect tree in WPT) and is temporarily disabled on this branch.

Trac ticket: https://core.trac.wordpress.org/ticket/64894

Follow-up to r58010.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@sirreal sirreal marked this pull request as ready for review July 13, 2026 21:51
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

pento pushed a commit that referenced this pull request Jul 14, 2026
The web-platform-tests data provider used `return` instead of `yield` for the last case in each file, preventing it from running.

Developed in #12509.

Follow-up to [58010].

See #64894.


git-svn-id: https://develop.svn.wordpress.org/trunk@62724 602fd350-edb4-49c9-b593-d223f7449a82
@sirreal

sirreal commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

Merged in r62724.

@sirreal sirreal closed this Jul 14, 2026
@sirreal sirreal deleted the fix/html-api-wpt-tests branch July 14, 2026 06:41
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Jul 14, 2026
The web-platform-tests data provider used `return` instead of `yield` for the last case in each file, preventing it from running.

Developed in WordPress/wordpress-develop#12509.

Follow-up to [58010].

See #64894.

Built from https://develop.svn.wordpress.org/trunk@62724


git-svn-id: http://core.svn.wordpress.org/trunk@62008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant