perf: add ErrorTypeAttribute to eliminate extra slice allocation - #643
Open
gaiaz-iusipov wants to merge 4 commits into
Open
perf: add ErrorTypeAttribute to eliminate extra slice allocation#643gaiaz-iusipov wants to merge 4 commits into
gaiaz-iusipov wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
=======================================
+ Coverage 85.5% 85.7% +0.1%
=======================================
Files 15 15
Lines 694 687 -7
=======================================
- Hits 594 589 -5
+ Misses 74 73 -1
+ Partials 26 25 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
How about removing this check in this PR? if value == "" {
return semconv.ErrorTypeOther
}Since, as far as I can tell, it's unreachable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.