Skip to content

fix(openai-codex): complete prompts over the streaming transport #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rafael-Silva-Oliveira wants to merge 5 commits into
base: main
Choose a base branch
from
+439 −114
Open

fix(openai-codex): complete prompts over the streaming transport #1243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5d990c
fix(openai-codex): complete prompts over the streaming transport
Rafael-Silva-Oliveira Aug 14, 2026
979269b
fix(openai-codex): stop replaying the stream and treat an abort as one
Rafael-Silva-Oliveira Aug 15, 2026
c68dae1
fix(openai-codex): close the last two replay routes into a live request
Rafael-Silva-Oliveira Aug 15, 2026
bb2676a
fix(openai-codex): report one abort result however the request ended
Rafael-Silva-Oliveira Aug 15, 2026
78adb9a
fix(openai-codex): keep refusals out of the completed prompt
Rafael-Silva-Oliveira Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/api/providers/__tests__/openai-codex-native-tool-calls.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,15 +475,20 @@ describe("OpenAiCodexHandler native tool calls", () => {
vi.spyOn(openAiCodexOAuthManager, "getAccessToken").mockResolvedValue("test-token")
vi.spyOn(openAiCodexOAuthManager, "getAccountId").mockResolvedValue("acct_test")

// Completions stream like everything else, so the SDK path is forced to fail and the
// hand-built SSE request is what these assertions inspect.
Reflect.set(handler, "client", {
responses: { create: vi.fn().mockRejectedValue(new Error("SDK unavailable")) },
})
const mockFetch = vi.fn().mockResolvedValue({
ok: true,
json: vi.fn().mockResolvedValue({
output: [
{
type: "message",
content: [{ type: "output_text", text: "done" }],
},
],
body: new ReadableStream({
start(controller) {
controller.enqueue(
new TextEncoder().encode('data: {"type":"response.output_text.delta","delta":"done"}\n\n'),
)
controller.close()
},
}),
})
global.fetch = mockFetch as any
Expand Down
Loading
Loading