feat: add resetOnEachIteration option to DslCounter#325
Open
prateekgupta-1 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
resetOnEachIteration(boolean)API method toDslCounter.Currently,
DslCounterwraps JMeter's nativeCounterConfigbut does not expose its built-in capability to reset the counter on each Thread Group iteration. Adding this option allows users to cleanly reset sequence variables on loop boundaries without needing custom JSR223 pre-processors.To improve user experience and prevent common configuration errors, calling
.resetOnEachIteration(true)will also automatically enable.perThread(true), as JMeter requires per-thread tracking for this feature to work.Changes
resetOnEachIteration(boolean)method toDslCounter.CounterConfig.setResetOnThreadGroupIteration()for both test execution and GUI generation.CodeBuilderto support generating this new method from JMX files.DslCounterTestto verify the counter reset behaviour.