[AS5812-54X] Upgrade kernel from 4.14 to 6.12#200
Open
vincentchiang-ec wants to merge 1 commit into
Open
Conversation
- modules/PKG.yml, modules/builds/Makefile: use onl-kernel-6.12-lts-x86-64-all - modules/builds: move drivers into src/ subdir with explicit Kbuild (obj-m += ...) so cross-module EXPORT_SYMBOL refs resolve at modpost time; required because newer kbuild won't treat sibling .c files as a single module group - platform-config r0 yml: kernel anchor *kernel-6-12 - cpld: i2c_driver.probe() single-arg signature + use i2c_client_get_device_id(); i2c_mux_add_adapter() loses the removed `class` arg; i2c_driver.remove() returns void - psu: i2c_driver.probe() single-arg signature + use i2c_client_get_device_id(); i2c_driver.remove() returns void - fan/leds: platform_driver.remove() returns void per kernel 6.11+ API - onlp platform_lib.h: IDPROM_PATH switch from /sys/devices/pci0000:00/.../1-0057 to /sys/bus/i2c/devices/1-0057 (old path no longer enumerates on 6.12) - onlp sysi.c: zero-init onlp_onie_info_t to avoid double-free on the failure path Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades AS5812-54X from kernel 4.14 to 6.12 LTS. Covers the per-platform changes plus the longer chain of kernel API breakage that comes from skipping 4.19 / 5.4 / 6.1.
Config
modules/PKG.yml,modules/builds/Makefile:KERNELSswitched toonl-kernel-6.12-lts-x86-64-allplatform-config/r0/.../x86-64-accton-as5812-54x-r0.yml: kernel anchor*kernel-4-14→*kernel-6-12Build layout
cpld/fan/leds/psu.cfrommodules/builds/intomodules/builds/src/with an explicit Kbuild (obj-m += ...). Newer kbuild builds each top-level.cas its own standalone module, so leds.c's references toas5812_54x_cpld_read/writefailedmodposteven though cpld.c exports them. The src/ subdir mirrors the convention already used by as5835-54x and other 6.12-ready platforms.Driver API (4.14 → 6.12)
cpld.c:i2c_driver.probe()single-arg signature; restore device id viai2c_client_get_device_id()i2c_mux_add_adapter()drops the removedclassargument (and the localclassvariable)i2c_driver.remove()returnsvoidpsu.c:i2c_driver.probe()single-arg signature +i2c_client_get_device_id()(body still consumesdev_id->driver_data)i2c_driver.remove()returnsvoidfan.c,leds.c:platform_driver.remove()returnsvoidper 6.11+ APIONLP
platform_lib.h:IDPROM_PATHswitched from the pci-bus path (/sys/devices/pci0000:00/.../1-0057/eeprom) to/sys/bus/i2c/devices/1-0057/eeprom; the old path no longer enumerates on 6.12sysi.c: zero-initonlp_onie_info_t onieto avoid the double-free path that has bitten other platforms on this branchTest plan
onlpm --force --build onl-platform-modules-x86-64-accton-as5812-54x:amd64— produces.debwithcpld.ko / fan.ko / leds.ko / psu.kounder/lib/modules/6.12.73-OpenNetworkLinux/onl/accton/x86-64-accton-as5812-54x/onlpm --force --build onlp-x86-64-accton-as5812-54x-r0:amd64onlpm --force --build onl-platform-config-x86-64-accton-as5812-54x-r0:amd64make amd64OK)onlpdumpsmoke test (pending HW access)🤖 Generated with Claude Code