🧹 Code health: Refactor duplicate duration measurement logic - #65
Open
gabrielrufino wants to merge 3 commits into
Open
🧹 Code health: Refactor duplicate duration measurement logic#65gabrielrufino wants to merge 3 commits into
gabrielrufino wants to merge 3 commits into
Conversation
Co-authored-by: gabrielrufino <31759891+gabrielrufino@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
1 similar comment
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
Co-authored-by: gabrielrufino <31759891+gabrielrufino@users.noreply.github.com>
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
1 similar comment
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 0
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
Co-authored-by: gabrielrufino <31759891+gabrielrufino@users.noreply.github.com>
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 6
"Build" : 1
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 10
"Build" : 1
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 6
"Build" : 1
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 5
"Build" : 0
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 7
"Build" : 1
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
@actalog/node-ciNode CI completed! Steps
pie title Step Durations (seconds)
"Install" : 14
"Build" : 1
"Lint" : 0
"Test" : 0
Statistics
Outdated packagesEnvironment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: The duplicated logic for measuring the execution duration of various steps (
install,build,lint,test) inaction.ymlwas refactored into a new, self-contained composite actionmeasure/action.yml.💡 Why: By extracting this logic, we eliminated the duplicated bash script block (
start=$(date +%s); ... echo "duration=..." >> $GITHUB_OUTPUT) spread across multiple steps, significantly improving maintainability and readability. Any future changes to the timing mechanism will now only require an update in one place.✅ Verification: Visually verified that the changes were applied properly. Simulated the bash block execution locally to ensure the timing logic operates as intended without syntax issues. Code review confirmed the refactor safely maintains the exact output interfaces (
duration) such that downstream comment-generating steps remain fully functional.✨ Result: A cleaner, DRYer core
action.ymlwhere steps focus on what command to run rather than how to time it.PR created automatically by Jules for task 462206085666814767 started by @gabrielrufino