fix(schema): add missing error codes to enums/error-code.json - #5982
fix(schema): add missing error codes to enums/error-code.json#5982garvitkaushik-123 wants to merge 1 commit into
Conversation
INVALID_PRICING_OPTION, INVALID_USAGE_DATA, DUPLICATE_REQUEST, TARGETING_TOO_NARROW, and CREATIVE_ID_EXISTS were used in docs and server code but absent from the canonical enum. Adds enum values, enumDescriptions, and enumMetadata recovery classifications for all five. Closes adcontextprotocol#5892
There was a problem hiding this comment.
Argus is not auto-reviewing this PR because it modifies protected paths that require human review (static/schemas/source/enums/error-code.json). A human reviewer should review and merge this PR; Argus will resume on subsequent PRs once these changes land on main.
bokelley
left a comment
There was a problem hiding this comment.
Thanks for chasing the drift. This cannot land as a 3.1 patch: #5892 explicitly deferred the error-vocabulary decision to 3.2, and DUPLICATE_REQUEST was rejected in that disposition. The current branch also fails the drift-disposition checks. Please rework this against the recorded 3.2 vocabulary decision, remove rejected codes, and update the canonical docs and enum together rather than treating all current prose references as normative.
Summary
enums/error-code.jsonthat are already referenced in documentation and server implementation but were absent from the canonical enum:INVALID_PRICING_OPTION— used inreport_usage.mdx,create_media_buy.mdx, andreport-usage-response.jsonexamplesINVALID_USAGE_DATA— used inreport_usage.mdxerror table andtask-handlers.tsvalidation logicDUPLICATE_REQUEST— used inreport_usage.mdxerror tableTARGETING_TOO_NARROW— used increate_media_buy.mdxerror tableCREATIVE_ID_EXISTS— used increate_media_buy.mdxandupdate_media_buy.mdxerror tablesenumDescriptions(prose with recovery classification) andenumMetadata(structured recovery + suggestion) so SDKs can consume them like any other standard codeCloses #5892
Test plan
python3 -c "import json; json.load(...)")enumDescriptionsandenumMetadataentries (no orphans in either direction)