[MWPW-197470] Onboard 7 new Image to PDF verbs#806
Open
maagrawal16 wants to merge 8 commits into
Open
Conversation
…778) * Fix delay with config-based A/B testing api initiation Resolves: [MWPW-194995(https://jira.corp.adobe.com/browse/MWPW-194995) **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=target-test **Implementation details:** `this.pageConfigPromise = null (line 189)` initializes the field so it's always defined on the instance. `this.pageConfigPromise = this.ensurePageConfig() `(line 792, inside initActionListeners when b === this.block) fires the fetch the moment the verb-widget finishes rendering (for performance reasons), no await so it doesn't block listener setup. The promise is stored so it can be joined later. `await (this.pageConfigPromise || this.ensurePageConfig()) `(line 580, in handleFileUpload) if the widget has rendered (normal path), we await the already in flight or resolved promise; if somehow pageConfigPromise is null (edge case: upload triggered before initActionListeners ran with the block), we fall back to calling it directly. The existing pageConfigFetched guard inside ensurePageConfig still prevents double execution. --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com> Co-authored-by: Manasvi Agrawal <maagrawal@adobe.com>
<!-- Before submitting, please review all open PRs. --> * Onboard resume builder Resolves: [MWPW-196557](https://jira.corp.adobe.com/browse/MWPW-196557) **Test URLs:** - Before: https://mwpw-196281--da-dc--adobecom.aem.page/acrobat/online/test/unity/resume-builder-copy?martech=off&unitylibs=stage - After: https://mwpw-196281--da-dc--adobecom.aem.page/acrobat/online/test/unity/resume-builder-copy?martech=off&unitylibs=resume-builder Note: his has to be tested once unity backend is also on stage --------- Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
<!-- Before submitting, please review all open PRs. --> * Allow word doc file for resume-builder verb Resolves: [MWPW-NUMBER](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?martech=off&unitylibs=stage&app!versions=latest - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?martech=off&unitylibs=resume-builder-word-doc&app!versions=latest
) <!-- Before submitting, please review all open PRs. --> * Add page count check for word doc for resume builder Resolves: [MWPW-198023](https://jira.corp.adobe.com/browse/MWPW-198023) **Test URLs:** - Before: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?unitylibs=stage - After: https://stage--da-dc--adobecom.aem.page/acrobat/online/ai-resume-builder?unitylibs=page-count --------- Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
maagrawal16
changed the title
maagrawal16
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
workflow-acrobat:image-to-pdf,bmp-to-pdf,gif-to-pdf,tiff-to-pdf,indd-to-pdf,psd-to-pdf,ai-to-pdf.Related Issue
Resolves: MWPW-196281
Test URLs