Skip to content

[MWPW-197381]Onboard express for resume builder verb#814

Merged
Ruchika4 merged 16 commits into
stagefrom
express-2
Jun 16, 2026
Merged

[MWPW-197381]Onboard express for resume builder verb#814
Ruchika4 merged 16 commits into
stagefrom
express-2

Conversation

@Ruchika4

@Ruchika4 Ruchika4 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator
  • Onboard resume builder for express

Resolves: MWPW-197381

Test URLs:

Testing Notes:

Drag & Drop

  • Drop listeners are attached to document.body (not scoped to a div), so dropping a file anywhere on the page triggers upload while the dropzone is in the viewport.
  • Listeners are added/removed via IntersectionObserver — dropping a file when the dropzone is scrolled out of view should not trigger upload.

File Input (Click to Upload)

  • Clicking the upload button opens the file picker restricted to image/jpeg, image/jpg, image/png, image/webp.
  • Selecting an unsupported file type should show a validation error toast.

Redirect Query Param (x_api_client_location)

  • On redirect, the URL should contain x_api_client_location computed from the page path: strips /express/ prefix, reverses path segments, joins with _.
  • Example: /express/create/resumex_api_client_location=resume_create
  • Verify the correct value appears in the redirect URL for the page under test.
  • Test page if created will need to be created inside a express folder

Transition Screen

  • Upload should show a splash/transition screen (from /express/unity/splashscreen fragment, mounted on body).
  • Verify it appears on file drop/select and clears on redirect.

User logged in status

  • Test the flow for anonymous users. There is a discussion going on where we might need to support signed in users to upload files too. However this PR doesn't touch that yet. So scope for this PR is anonymous user and signed in user experience will be tested separately

Regression

  • Please do a regression on an existing acrobat verb with unitylibs=express-2 to make sure everything works as expected

sanjayms01 and others added 15 commits June 4, 2026 16:30
…778)

* Fix delay with config-based A/B testing api initiation

Resolves: [MWPW-194995(https://jira.corp.adobe.com/browse/MWPW-194995)

**Test URLs:**
- Before:
https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=stage
- After:
https://stage--da-dc--adobecom.aem.page/acrobat/online/compress-pdf?martech=off&unitylibs=target-test

**Implementation details:**
`this.pageConfigPromise = null (line 189)` initializes the field so it's
always defined on the instance.
`this.pageConfigPromise = this.ensurePageConfig() `(line 792, inside
initActionListeners when b === this.block) fires the fetch the moment
the verb-widget finishes rendering (for performance reasons), no await
so it doesn't block listener setup. The promise is stored so it can be
joined later.
`await (this.pageConfigPromise || this.ensurePageConfig()) `(line 580,
in handleFileUpload) if the widget has rendered (normal path), we await
the already in flight or resolved promise; if somehow pageConfigPromise
is null (edge case: upload triggered before initActionListeners ran with
the block), we fall back to calling it directly. The existing
pageConfigFetched guard inside ensurePageConfig still prevents double
execution.

---------

Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com>
Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com>
Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Ratko Zagorac <90400759+zagi25@users.noreply.github.com>
Co-authored-by: Manasvi Agrawal <maagrawal@adobe.com>
<!-- Before submitting, please review all open PRs. -->

* Onboard resume builder

Resolves: [MWPW-196557](https://jira.corp.adobe.com/browse/MWPW-196557)

**Test URLs:**
- Before:
https://mwpw-196281--da-dc--adobecom.aem.page/acrobat/online/test/unity/resume-builder-copy?martech=off&unitylibs=stage
- After:
https://mwpw-196281--da-dc--adobecom.aem.page/acrobat/online/test/unity/resume-builder-copy?martech=off&unitylibs=resume-builder

Note: his has to be tested once unity backend is also on stage

---------

Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro.local>
@aem-code-sync

aem-code-sync Bot commented Jun 15, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run all PSI checks
  • Re-run failed PSI checks
  • Re-sync branch
Commits

@asonnalagi

Copy link
Copy Markdown
Collaborator

Validated from A.com side. All looks fine. Test results are in the task: MWPW-198704

@Ruchika4 Ruchika4 merged commit de1b436 into stage Jun 16, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants