Update/verify dep vendoring#132
Open
Tim Hockin (thockin) wants to merge 11 commits into
Open
Conversation
Collaborator
yes please! |
Tim Hockin (thockin)
force-pushed
the
add-vendoring
branch
from
78740f8 to
2d2c34a
Compare
Collaborator
Author
|
Now vendors all go.mod directories |
I cannot say why this removed go code from within LICENSES (GOROOT, I guess?) or why that code was there in the first place. The GOROOT change is needed when the compiler in use doesn't match the go env, causing it to flag stdlib as "not a module".
Tim Hockin (thockin)
force-pushed
the
add-vendoring
branch
from
2d2c34a to
4785e85
Compare
Collaborator
Author
|
I broke up the large commits into script-changes and run-the-script commits. the "run" commits are just the output of running the script. |
Davanum Srinivas (dims)
approved these changes
May 31, 2026
Collaborator
Davanum Srinivas (dims)
left a comment
Davanum Srinivas (dims)
left a comment
There was a problem hiding this comment.
LGTM
the individual vendor/ for each tool ... we'll get used to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an update/verify script pair to check
go mod vendorin the main module. Should we do this in sub-modules too?Fixes #19