Feature/flexible persistence via ListOptions#136
Open
Grant McCloskey (MushuEE) wants to merge 2 commits into
Open
Feature/flexible persistence via ListOptions#136Grant McCloskey (MushuEE) wants to merge 2 commits into
Grant McCloskey (MushuEE) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #135
Decouples the control plane persistence layer (
store.Interface) from rigid listing constraints by introducing a generic, non-ossifying query filtering surface.Problem
Currently, the persistence listing methods (
ListWorkersandListActors) are all-or-nothing. To filter workers by pool or namespace, the scheduler must fetch all records from the database and perform in-memory filtering in Go. This approach:Solution
store.ListOptions: Added a genericListOptionsstruct with aFieldSelector map[string]stringparameter to the storageInterfacelisting methods.matchesWorker,matchesActor) in theateredispackage. This lets the storage engine filter items internally before returning them.AssignWorkerStep) to pass the options cleanly.actor_idto claim ready workers, and actorstatus).Architectural Advantages
node_name,gpu_type) does not require changing thestore.Interfacesignatures.FieldSelectordirectly into indexed SQLWHEREclauses.