harden: externalize secrets, pin images, add healthcheck + CI smoke test#1
Merged
Conversation
Security:
- Remove the committed real-format LORE_API_KEY plus the dev ADMIN_API_KEY /
JWT_SECRET from docker-compose.yml; read them from a gitignored .env
(${VAR:?...} so compose refuses to start if unset). Add .env.example +
.gitignore. NOTE: the previously-committed lore_sk_ key must be revoked on
the Lore side — it is in git history and should be treated as compromised.
Reproducibility / correctness:
- Pin all four images off :latest (agentlens 0.12.2, agentgate 0.12.1,
lore 1.1.1, agentkit-mesh 1.3.0).
- Add a healthcheck to agentgate (node-based probe; the image has no curl) and
gate agentlens on agentgate + mesh being healthy, so startup is deterministic.
- Fix the README/compose contradiction (it claimed Lore/Mesh build locally;
all four actually pull from Docker Hub) and document the .env step.
CI:
- Add a smoke-test workflow: docker compose config, up --wait (health-gated),
poll the four documented /health endpoints, down -v. The repo previously had
no CI verifying the stack composes.
Verified locally: all 5 containers report healthy and all four health endpoints
return 200.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Hardens the
agentkit-stackmeta-repo — previously a singledocker-compose.ymlwith a committed secret and no CI.Security
LORE_API_KEY(plus devADMIN_API_KEY/JWT_SECRET) fromdocker-compose.yml; they're now read from a gitignored.envvia${VAR:?...}(compose refuses to start if unset). Added.env.example+.gitignore.lore_sk_…key is in git history — revoke it on the Lore side, it should be treated as compromised. (That part is yours; I can't issue a new key.)Reproducibility / correctness
:latest→agentlens:0.12.2,agentgate:0.12.1,lore:1.1.1,agentkit-mesh:1.3.0.agentgate(node-based — the image has nocurl) and gatedagentlensonagentgate+meshbeing healthy for deterministic startup..envstep.CI
compose config→up --wait(health-gated) → poll the 4/healthendpoints →down -v. The repo had no CI before.Verification
Brought the full stack up locally with the externalized
.env: all 5 containers healthy, all 4 health endpoints return 200.🤖 Generated with Claude Code