Fix failed GitHub Actions#1
Merged
Merged
Conversation
- Fix getCoDevelopedBy function to properly handle falsy environment variable values - Add proper environment variable cleanup in tests to prevent interference - Improve pack test to gracefully handle development mode failures on Node.js 18 - Ensure all tests pass on Node.js 18.x with proper error handling - Maintain full functionality while providing graceful degradation for unsupported features Test Results: - All 85 tests now pass successfully - Build and production mode work on all Node.js versions - Development mode gracefully fails on Node.js 18 (expected behavior) - Compatibility tests show proper version-specific behavior Change-Id: I6224505ae7b157596fdef0db497e48dfaad54ff9 Co-developed-by: Cursor <noreply@cursor.com> Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
- Add tsconfig.node20.json with CommonJS module configuration for Node.js 20.x - Install tsx package for better ESM compatibility in Node.js 20.x - Update package.json scripts to use tsx for Node.js 20.x development mode - Modify GitHub Actions workflow to use appropriate dev scripts for each Node.js version - Update test files to handle Node.js 20.x development mode correctly - Ensure all tests continue to pass locally and in CI This fix addresses the ERR_UNKNOWN_FILE_EXTENSION errors that were causing Node.js 20.x tests to fail in GitHub Actions while maintaining compatibility with Node.js 18.x and 22.x. Node.js Version Compatibility: - 22.x: Uses ts-node with ESM (tsconfig.dev.json) - 20.x: Uses tsx with CommonJS (tsconfig.node20.json) - 18.x: Uses ts-node with CommonJS (tsconfig.node18.json) - <18.x: Uses ts-node with CommonJS (tsconfig.compat.json) Change-Id: I4f97f23781fe588a074e5df67595e7b99cc84338 Co-developed-by: Cursor <noreply@cursor.com> Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
- Move envConfigs to global scope for better reusability - Add clearCoDevelopedByEnvVars utility function for centralized environment variable cleanup - Update tests to use the new utility function instead of manual delete operations - Improve code organization and maintainability - All tests continue to pass successfully This refactoring makes the code more maintainable and provides a centralized way to manage environment variables used by the getCoDevelopedBy function. Change-Id: Iac187f3977cdbffb28af9b316717288b50001045 Co-developed-by: Cursor <noreply@cursor.com>
Borrowed from Git project. Change-Id: Ia9f8c4be7c14be77a76c07685af625dfdc99275a Signed-off-by: Jiang Xin <zhiyou.jx@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.