Bump actions/checkout from 4 to 7 - #14
Open
dependabot[bot] wants to merge 2 commits into
Open
Conversation
* fix: restore clipping path support in PageDrawer The Note box text in certain PDFs (e.g. WoW manual) was invisible because the decorative frame image was painted over the text without the intended clipping restriction. Root cause 1 — W/W* operators were silently ignored clip() only stored clipWindingRule but never called intersectClippingPath(). The clipping path in the graphics state was therefore never updated, so images were drawn over the full page instead of just the frame/border area. Fixed by immediately calling intersectClippingPath(linePath) inside clip(), matching the behaviour of the original Apache PDFBox. Root cause 2 — drawImage() never applied the current clipping path Even after fixing clip(), images were drawn without respecting the active clip because drawImage() never called setClip() before painting. Fixed by adding setClip() at the start of drawImage(). Regression fix — image flipping on pages with tiling patterns After the above fixes, images on pages that use a Pattern fill (/P1 scn) were rendered upside-down. The cause was drawTilingPattern(): it switches to a temporary Canvas for the pattern, calls setClip() which updates clipSaveCount to a save-level valid only for that temporary Canvas, then returns without restoring clipSaveCount. The next setClip() call on the main Canvas called canvas.restoreToCount() with a stale value, rolling the main Canvas back past the page y-flip transform, which flipped every subsequent image. Fixed by saving and restoring clipSaveCount around the tiling pattern rendering, the same way lastClip is already handled.
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/checkout from 4 to 7.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
9c091bbupdate error wording (#2467)1044a6dgetting ready for checkout v7 release (#2464)f028218Bump the minor-npm-dependencies group across 1 directory with 3 updates (#2462)d914b26upgrade module to esm and update dependencies (#2463)537c7efBump@actions/coreand@actions/tool-cacheand Remove uuid (#2459)130a169Bump js-yaml from 4.1.0 to 4.2.0 (#2461)7d09575Bump flatted from 3.3.1 to 3.4.2 (#2460)0f9f3aaBump actions/publish-immutable-action (#2458)f9e715ablock checking out fork pr for pull_request_target and workflow_run (#2454)df4cb1cUpdate changelog for v6.0.3 (#2446)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)