Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/plugins/Label_2P_FM3.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,13 @@ describe('Label 2P Preamble FM3', () => {
expect(decodeResult.formatted.description).toBe('Flight Report');
expect(decodeResult.formatted.items.length).toBe(0);
});

test('missing FM3 preamble', () => {
// 7 comma-parts but no `FM3 ` token in parts[0]
message.text = '1217,1312,+ 43.77,- 70.18, 39981, 426, 25';
const decodeResult = plugin.decode(message);

expect(decodeResult.decoded).toBe(false);
expect(decodeResult.decoder.decodeLevel).toBe('none');
});
});
2 changes: 1 addition & 1 deletion lib/plugins/Label_2P_FM3.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export class Label_2P_FM3 extends DecoderPlugin {

if (parts.length === 7) {
const header = parts[0].split('FM3 ');
if (header.length == 0) {
if (header.length < 2) {
// can't use preambles, as there can be info before `FM4`
// so let's check if we want to decode it here
ResultFormatter.unknown(decodeResult, message.text);
Expand Down
10 changes: 10 additions & 0 deletions lib/plugins/Label_2P_FM4.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,14 @@ describe('Label_2P Preamble FM4', () => {
expect(decodeResult.formatted.description).toBe('Flight Report');
expect(decodeResult.formatted.items.length).toBe(0);
});

test('missing FM4 preamble', () => {
// 10 comma-parts but no `FM4` token in parts[0]
message.text =
'KIAD,OMAA,140256,1448, 39.43,- 75.62,23228,328, 43.5, 72500';
const decodeResult = plugin.decode(message);

expect(decodeResult.decoded).toBe(false);
expect(decodeResult.decoder.decodeLevel).toBe('none');
});
});
2 changes: 1 addition & 1 deletion lib/plugins/Label_2P_FM4.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class Label_2P_FM4 extends DecoderPlugin {

if (parts.length === 10) {
const header = parts[0].split('FM4');
if (header.length == 0) {
if (header.length < 2) {
// can't use preambles, as there can be info before `FM4`
// so let's check if we want to decode it here
ResultFormatter.unknown(decodeResult, message.text);
Expand Down
10 changes: 10 additions & 0 deletions lib/plugins/Label_2P_FM5.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,14 @@ describe('Label_2P Preamble FM5', () => {
expect(decodeResult.formatted.description).toBe('Flight Report');
expect(decodeResult.formatted.items.length).toBe(0);
});

test('missing FM5 preamble', () => {
// 12 comma-parts but no `FM5 ` token in parts[0]
message.text =
'EIDW,OMAA,113522,1540,+45.147, +23.384,35002,116.24,502 ,36900,ETD23N ,';
const decodeResult = plugin.decode(message);

expect(decodeResult.decoded).toBe(false);
expect(decodeResult.decoder.decodeLevel).toBe('none');
});
});
2 changes: 1 addition & 1 deletion lib/plugins/Label_2P_FM5.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export class Label_2P_FM5 extends DecoderPlugin {

if (parts.length === 12) {
const header = parts[0].split('FM5 ');
if (header.length == 0) {
if (header.length < 2) {
// can't use preambles, as there can be info before `FM4`
// so let's check if we want to decode it here
ResultFormatter.unknown(decodeResult, message.text);
Expand Down