Skip to content

Added HTTP Authentication#33

Open
msigley wants to merge 3 commits into
amnuts:masterfrom
msigley:master
Open

Added HTTP Authentication#33
msigley wants to merge 3 commits into
amnuts:masterfrom
msigley:master

Conversation

@msigley

@msigley msigley commented Apr 3, 2018

Copy link
Copy Markdown

No description provided.

@bbalet

bbalet commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Please don't merge this PR.
If you want to restrict the access, you can move the script in a sub folder and setup your web server accordingly (.htacces in this folder or nginx conf for this path) Moreover, the problem of this PR is that it default this behaviour for everyone.

@msigley

msigley commented Apr 4, 2018

Copy link
Copy Markdown
Author

I have disabled the http authentication by default to preserve the existing behavior.

I must say though that it is not a very good idea security wise to have the script publicly accessible by default. The changes I made were based on the default functionality of the wincache gui script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants